491911 - endKinetic didn't call endPanning, so screen updates sometimes stopped

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Ben Combee (:bcombee)]

Attachment: Add missing endPanning call

In the restructure of the kinetic code, we missed calling Browser.canvasBrowser.endPanning() in endKinetic().  Since that's called to end all drags now, we never called endPanning, leaving the canvasbrowser in a high-latency state.

Comment 1

[Ben Combee (:bcombee)]

Attachment: Try #2 - make startPanning/endPanning do nothing if state doesn't change, call endPanning in more situations

Comment 2

[Ben Combee (:bcombee)]

Attachment: Try #3 - guard internal state of kineticData with isActive call

Comment 4

[Stuart Parmenter]

Comment on attachment 376302 [details] [diff] [review]
Try #3 - guard internal state of kineticData with isActive call

what do the extra checks in startPanning and endPanning help with? 

Please just early return in endKinetic, rather than putting the whole function in another { }

+    }
+    else {
please put these on one line

Comment 5

[Ben Combee (:bcombee)]

Attachment: Try #4 - incorporated Stuart's feedback

I removed the CanvasBrowser changes -- those were experiments to try to work around mismatched startPanning/endPanning

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/03b08996eeb4