49196 - Buttons not showing up in common dialogs

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

- open mail compose window
- enter some text to get it to be modified
- click closebox

expected:
- do you want to save? yes/no/cancel dialog
- clicking no closes window

actual:
- message not sent, save or cancel? save/cancel dialog
- clicking cancel doesn't close window.

There's no way to close a mail window w/out saving it.

Comment 1

[Mike Pinkerton (not reading bugmail)]

cc'ing hyatt, he recently touched the common dialog stuff.

Comment 2

[Simon Fraser [no longer active]]

I see the problem here. The platform dialog overlay uses hidden="true" on the 
extra buttons, but hyatt changed commonDialogs.js to only set/unset "collapsed"

Comment 3

[Simon Fraser [no longer active]]

Patch (which fixes Mac, at least)
Index: mozilla/xpfe/global/resources/content/mac/platformDialogOverlay.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/mac/
platformDialogOverlay.xul,v
retrieving revision 1.16
diff -w -r1.16 platformDialogOverlay.xul
14,15c14,15
<     <button class="exit-dialog" id="Button3" value="" hidden="true" oncommand=
"doButton3();"/>
<     <button class="exit-dialog" id="Button2" value="" hidden="true" oncommand=
"doButton2();"/>
---
>     <button class="exit-dialog" id="Button3" value="" collapsed="true" oncommand="doButton3();"/>
>     <button class="exit-dialog" id="Button2" value="" collapsed="true" oncommand="doButton2();"/>
22,23c22,23
<     <button class="exit-dialog" id="Button3" value="" hidden="true" oncommand=
"doButton3();"/>
<     <button class="exit-dialog" id="Button2" value="" hidden="true" oncommand=
"doButton2();"/>
---
>     <button class="exit-dialog" id="Button3" value="" collapsed="true" oncommand="doButton3();"/>
>     <button class="exit-dialog" id="Button2" value="" collapsed="true" 
oncommand="doButton2();"/>

Comment 4

[Jean-Francois Ducarroz]

Here is the diff for WIndow:

Index: platformDialogOverlay.xul
===================================================================
RCS file: 
/cvsroot/mozilla/xpfe/global/resources/content/win/platformDialogOverlay.xul,v
retrieving revision 1.14
diff -r1.14 platformDialogOverlay.xul
15,16c15,16
<     <button class="exit-dialog" id="Button2" value="&cancelButton.label;" 
hidden="true" onclick="doButton2()"/>
<     <button class="exit-dialog" id="Button3" value="&cancelButton.label;" 
hidden="true" onclick="doButton3()"/>
---
>     <button class="exit-dialog" id="Button2" value="&cancelButton.label;" 
collapsed="true" onclick="doButton2()"/>
>     <button class="exit-dialog" id="Button3" value="&cancelButton.label;" 
collapsed="true" onclick="doButton3()"/>
24,25c24,25
<     <button class="exit-dialog" id="Button2" value="&cancelButton.label;" 
hidden="true" onclick="doButton2()"/>
<     <button class="exit-dialog" id="Button3" value="&cancelButton.label;" 
hidden="true" onclick="doButton3()"/>
---
>     <button class="exit-dialog" id="Button2" value="&cancelButton.label;" 
collapsed="true" onclick="doButton2()"/>
>     <button class="exit-dialog" id="Button3" value="&cancelButton.label;" 
collapsed="true" onclick="doButton3()"/>

Comment 5

[Jean-Francois Ducarroz]

Reassign to sfraser has he found the problem. BTW, r=ducarroz

Comment 6

[lchiang]

*** Bug 49218 has been marked as a duplicate of this bug. ***

Comment 7

[Jean-Francois Ducarroz]

*** Bug 49219 has been marked as a duplicate of this bug. ***

Comment 8

[Simon Fraser [no longer active]]

Fix checked in.

Comment 9

[Jean-Francois Ducarroz]

*** Bug 49238 has been marked as a duplicate of this bug. ***

Comment 10

[Charles Manske]

*** Bug 49260 has been marked as a duplicate of this bug. ***

Comment 11

[Jean-Francois Ducarroz]

*** Bug 49275 has been marked as a duplicate of this bug. ***

Comment 12

[R.K.Aa.]

*** Bug 49315 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

*** Bug 49315 has been marked as a duplicate of this bug. ***

Comment 14

[Tracy Walker [:tracy]]

marking as verified

Comment 15

[R.K.Aa.]

*** Bug 49328 has been marked as a duplicate of this bug. ***

Comment 16

[Simon Fraser [no longer active]]

*** Bug 50111 has been marked as a duplicate of this bug. ***