Closed Bug 491989 Opened 14 years ago Closed 14 years ago

TM: "TypeError: String is not a constructor"

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jruderman, Assigned: gal)

References

Details

(Keywords: testcase, verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Use string constructor fastpath only if argc == 1. We can fall back onto the regular constructor otherwise.
950 bytes, patch
dmandelin
: review+
Details | Diff | Splinter Review 
for (let i = 0; i < 5; ++i)
  new String(new String(), 2);

Without -j: No errors
With -j:    TypeError: String is not a constructor

Testing with the patch for bug 491965, fwiw.
This happens even in a clean TM tree.
Slow natives fallout. Doesn't affect branch IMO. Blocking 1.9.2?
No jit code ever runs here. Trace recording seems to interfere with the interpreter execution.
Attachment #376778 - Flags: review?(dmandelin) → review+
Looks to me like accidental fallout from 487134, so this is not on branch. Hence no need to block on it. But making this a dependency.
Blocks: 487134
Flags: blocking1.9.1?
http://hg.mozilla.org/tracemonkey/rev/be7969c1ec5d
Whiteboard: fixed-in-tracemonkey
Flags: blocking1.9.1? → blocking1.9.1+
This doesn't affect branch. My b? was accidental.
Flags: blocking1.9.1+
http://hg.mozilla.org/mozilla-central/rev/be7969c1ec5d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: wanted1.9.1+
js1_8_1/trace/trace-test.js
http://hg.mozilla.org/tracemonkey/rev/61892f57b46a
Flags: in-testsuite+
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
cvsroot/mozilla/js/tests/js1_8_1/trace/trace-test.js,v  <--  trace-test.js
new revision: 1.14; previous revision: 1.13

/cvsroot/mozilla/js/tests/shell.js,v  <--  shell.js
You need to log in before you can comment on or make changes to this bug.