Closed
Bug 492106
Opened 16 years ago
Closed 16 years ago
Grab bag of minor WinCE fixes
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
12.79 KB,
patch
|
rwinchel
:
review+
|
Details | Diff | Splinter Review |
Collect a few minor fixes to the WinCE glue code from the Flash team:
-- sin, cos, and tan can return bogus values when called with huge values; add WinCE/ARM specific code to MathUtilsWin.cpp to work around it.
-- VMPI functions for MMgc needed some WinCE-specific love
-- SpyUtilsWin.cpp didn't compile with UNICODE mode
-- removed redundant OutputDebugString call from VMPI_debugLog, since VMPI_log is already doing that
Attachment #376477 -
Flags: review?(rwinchel)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 376477 [details] [diff] [review]
Patch
VMPI_getVMPageCount is out of date for WinCE and needs to be updates with subsequent patch.
Attachment #376477 -
Flags: review?(rwinchel) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
Hmm... before I attempt to land this: Tommy, are you already planning on updating this file as part of recent OOM fixes? (Or have you already done so?)
|
||
Comment 3•16 years ago
|
||
Steven: I don't think the OOM work has incorporated many of these fixes, and I don't think they're going to. So far as I know the major patches have landed already.
|
||
Comment 4•16 years ago
|
||
yeah I have no outstanding patches of this area. Most of the Spy/Wince changes were from Erik/Rishit.
|
|
Assignee | |
Comment 5•16 years ago
|
||
This bug is defunct, changes were pushed in other bugsets.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 6•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•