492112 - "ASSERTION: Shouldn't be trying to restyle non-elements directly" with colgroup

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Shouldn't be trying to restyle non-elements directly: '!aContent || aContent->IsNodeOfType(nsINode::eELEMENT)', file /Users/jruderman/central/layout/base/nsStyleChangeList.cpp, line 96

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is sort of a regression from bug 490173.  In this case, the textnode's display is not none, but the frame is suppressed inside the colgroup, so we have an undisplayed content entry for that node.  

I could do some more work inside the frame constructor to detect this case and not create an undisplayed content entry if we're being suppressed due entirely to our parent and not our own style data, but it would make more sense to me to not assert in nsStyleChangeList if the restyle is a frame reconstruct, since that makes sense for non-elements.

David, any objections to the latter?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Pushed a crashtest and fix for this as part of http://hg.mozilla.org/mozilla-central/rev/ae03e9085759

Comment 3

[Intermittent Failures Robot]

1 failures in 5073 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=492112&startday=2019-08-19&endday=2019-08-25&tree=all