Closed Bug 492186 Opened 11 years ago Closed 11 years ago

Crash [@ nsGenericElement::GetTagName] with altGlyphDef and getBBox()

Categories

(Core :: SVG, defect, critical)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: longsonr)

References

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(2 files)

Attached image testcase
See testcase, which crashes current trunk build on load.

http://crash-stats.mozilla.com/report/index/34ebddf5-ac9e-4fd2-bd5b-e7a4a2090509
0  	xul.dll  	nsGenericElement::GetTagName  	 content/base/src/nsGenericElement.cpp:2039
1 	xul.dll 	nsSVGDisplayContainerFrame::GetBBoxContribution 	layout/svg/base/src/nsSVGContainerFrame.cpp:276
2 	xul.dll 	nsSVGUtils::GetBBox 	layout/svg/base/src/nsSVGUtils.cpp:1315
3 	xul.dll 	nsSVGSVGElement::GetBBox 	content/svg/content/src/nsSVGSVGElement.cpp:773
4 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
5 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2474
Depends on: 488314
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #376649 - Flags: review?(jwatt)
Blocks: 488314
No longer depends on: 488314
Comment on attachment 376649 [details] [diff] [review]
patch

not sure where jwatt is
Attachment #376649 - Flags: review?(jwatt) → review?(roc)
Comment on attachment 376649 [details] [diff] [review]
patch

Thanks! don't forget to check in the crashtest.
Attachment #376649 - Flags: review?(roc) → review+
checked in http://hg.mozilla.org/mozilla-central/rev/7fcb443a08ce
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The crashtest doesn't crash for me locally on windows but it still crashes on the mac unit test box. Disabled crashtest and reopened for now (http://hg.mozilla.org/mozilla-central/rev/b51a6a73bb65)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The patch seems to fix Linux and Windows but not Mac? Any idea why Jonathan?
Flags: in-testsuite+ → in-testsuite?
Actually maybe this did work after all as one of the mac unit test boxes ran the crashtest successfully. I'll try reenabling it on the try server shortly.
No crash here on OS X 10.5.
It's possible that crashing "Everythingelse" box ran the crashtest on a build that didn't have the patch... see also bug 471281 comment 45.
Bug 499161 is fixed, so I think we should re-enable the crashtest and see what happens.
Marking as fixed as the code to fix is in. Will reenable the crashtest later.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Flags: in-testsuite? → in-testsuite+
Crash Signature: [@ nsGenericElement::GetTagName]
You need to log in before you can comment on or make changes to this bug.