Closed
Bug 492422
Opened 15 years ago
Closed 15 years ago
nsAutoSyncManager::Observe could return random data
Categories
(MailNews Core :: Networking: IMAP, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wolfiR, Assigned: wolfiR)
Details
Attachments
(1 file)
|
644 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
gcc thinks (and from a short look I do as well) that nsAutoSyncManager::Observe could hit the end w/o actually returning a defined value. The NS_IOSERVICE_OFFLINE_STATUS_TOPIC and NS_IOSERVICE_GOING_OFFLINE_TOPIC cases don't return anything while the other cases return mainly NS_OK.
|
Assignee | |
Comment 1•15 years ago
|
||
This fixes it but probably cleaning up a bit more wouldn't hurt or make it explicit in the affected else if cases.
|
||
Updated•15 years ago
|
Attachment #376772 -
Flags: superreview?(bienvenu)
Attachment #376772 -
Flags: review?(bienvenu)
|
||
Updated•15 years ago
|
Attachment #376772 -
Flags: superreview?(bienvenu)
Attachment #376772 -
Flags: superreview+
Attachment #376772 -
Flags: review?(bienvenu)
Attachment #376772 -
Flags: review+
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/comm-central/rev/759e9261b17b
Assignee: nobody → mozilla
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•