492426 - can create lots of safebrowsing notification bars

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Samuel Sidler (old account; do not CC)]

This happens using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090511 Shiretoko/3.5b5pre

STR:
  1. Go to http://www.mozilla.com/firefox/its-an-attack.html
  2. "Ignore this warning"
  3. Go to http://www.mozilla.com/firefox/its-an-attack.html again
  4. "Ignore this warning"
  5. Dismiss the notification bar
  6. Dismiss the notification bar
  7. Wait, what?

Gavin said this is pretty easy to fix.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I guess we should just remove any existing notifications when displaying the new one:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#2361

Comment 2

[Joe Bowser]

Attachment: Simple if statement that checks if this notification already exists.

Just check to see if the current notification is not null, AND is not one that is noticibly different from the phishing bug.

Comment 3

[Samuel Sidler (old account; do not CC)]

Comment on attachment 395944 [details] [diff] [review]
Simple if statement that checks if this notification already exists.

Is Gavin the right reviewer here?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I think we probably want to remove the current notification and replace it with the new one, in the case where we're changing from one site to another (or one type of block or another). You can do that with removeNotification.

Think you could  whip up a patch that does that, Joe?

Comment 5

[Joe Bowser]

Doing that now.

Comment 6

[Joe Bowser]

Attachment: Checks for the error and removes it if it exists, so the 2nd one has priority

This checks for the bar, removes it and places the new bar.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 396322 [details] [diff] [review]
Checks for the error and removes it if it exists, so the 2nd one has priority

Thanks for the patch, looks good! Just a couple of style nits:

-remove the "!= null"
-add a space after "if"
-omit the braces.

whoever checks this in can just fix that on checkin, but feel free to also attach an updated patch if you'd like to expedite the process.

Comment 8

[Joe Bowser]

Attachment: Cleaned patch with minor style changes

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e4f9310ecd0a