492429 - crash [@ nsMsgSearchSession::GetNextUrl()] due to de-referenced null GetRunningScope()

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

I kicked off a search in the 'search messages...' thing on an IMAP account.  I closed the search window before it completed.  While continuing to use Thunderbird normally, it crashed:

nsMsgSearchSession::GetNextUrl
    at mailnews/base/search/src/nsMsgSearchSession.cpp:497
nsMsgSearchSession::OnStopRunningUrl
    at mailnews/base/search/src/nsMsgSearchSession.cpp:384
nsImapMailFolder::SetUrlState
    at mailnews/imap/src/nsImapMailFolder.cpp:6160

In:
  495   nsMsgSearchScopeTerm *currentTerm = GetRunningScope();
  496   EnableFolderNotifications(PR_FALSE);
  497   nsCOMPtr <nsIMsgFolder> folder = currentTerm->m_folder;

currentTerm is 0x0, explaining our crash.

Arguably the null de-reference shouldn't happen.  Maybe the search window should do a better job of interrupting the search or something too.

Comment 1

[Wayne Mery (:wsmwk)]

oops. crashes aren't enhancements :)

Comment 2

[Wayne Mery (:wsmwk)]

this is a topcrash for 3.0b4pre (#8). goes back to 3.0b2, possibly further.

bp-33abca4c-fea5-425e-a67c-3cd9f2090819 and bp-b123db03-f060-4d7a-b762-2631b2090829 both mention smart folders, eg "was using smart folders and was navigating to one of my trash cans and it crashed while loading one of my imap trash folders"

bp-ebc41995-a0bc-4654-bfe9-0e0072090604 "Just did a search on some folders: 2 line items, To or CC and From with the same search string. It wouldn't "stop" so I closed the search dialogue box. Then TB crashed."

Comment 3

[David :Bienvenu]

Attachment: check for null search term

this should fix it...though I don't know what the underlying cause is.

Comment 4

[David :Bienvenu]

would be good to get this into b4 to see if the crash goes away, or a new one appears...

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 399101 [details] [diff] [review]
check for null search term

Yep, let's try this and see what happens.

Comment 6

[David :Bienvenu]

fix checked in.