Closed Bug 492447 Opened 14 years ago Closed 14 years ago

Test field validation (invalidFields() in app_model)

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wenzel, Assigned: wenzel)

References

Details

Attachments

(1 file)

Bug 491095 introduced a very simple replacement for the complicated (and unused) invalidFields() method in app_model.php, though unfortunately only in the Collections model.

We need to remove the old method, move the new one to app_model.php, and write tests.

It also needs to include a test for the bulk translation validation from bug 456132 comment 55.
Depends on: 491095, 456132
There you go, fresh from the test oven.
Attachment #376834 - Flags: review?(jbalogh)
Comment on attachment 376834 [details] [diff] [review]
Field validation tests goodness

This patch is made of win and awesome.  Goodbye 8 levels of nesting!
Attachment #376834 - Flags: review?(jbalogh) → review+
Committed to r25583.

QA: If you have access to the tests, the tests for app_model should contain some tests for validation now, and be all green of course. Otherwise, this patch is transparent for you.
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: push-needed
Resolution: --- → FIXED
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.