Closed
Bug 492501
Opened 15 years ago
Closed 15 years ago
Unable to get next 500 news messages....
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: martin.andersson, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.00 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729) Build Identifier: Shredder/3.0b3pre I'm using Shredder (TB 3.0b3pre) and the problem I have is that I can not get the next 500 messages from any of my news accounts. When I subscribe to a new group it fetches the first 500, or as may as I say. But when I then want to fetch older messages from the menu item "File\Get Next 500 news Messages", then it's grayed out (disabled). I've also noticed that this menu item sometimes disappears. Reproducible: Always Steps to Reproduce: 1. Select subscribed news group 2. From main menu, select "File\Get Next 500 news Messages" (disabled) Actual Results: Menu item "Get Next 500 news Messages" is disabled. Expected Results: The menu item should be active.
Assignee | ||
Comment 1•15 years ago
|
||
Confirming on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090511 Shredder/3.0b3pre
Assignee: nobody → bugzilla
Blocks: 462681
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Target Milestone: --- → Thunderbird 3.0b3
Assignee | ||
Comment 2•15 years ago
|
||
The problem is that bug 462681 removed the server variable without doing an adjustment inside the if statement, so the code just throws on the QueryInterface. I've also made the additional change to drop the check for the type being "nntp" and just rely on checking for the nsINntpIncomingServer interface - I think that is reasonable as if nsINntpIncomingServer isn't an nntp server then the server object shouldn't be implementing that interface. I've also put the server variable back in - this avoids crossing the xpcom boundary twice which we would have needed with two folder.server calls.
Attachment #376878 -
Flags: review?(bienvenu)
Updated•15 years ago
|
Attachment #376878 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/0b3d38a88712 I think this should go in litmus - it should be easy to formulate a test from comment 0.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Comment 4•15 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=7713
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•