492531 - Optimize some CSS and Reflow classes for memory usage

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: patch [pushed: comment 3]

These are the wins:

RuleHash: 8bytes
nsStyleContent: 8bytes
nsStyleSVGReset: 8bytes
nsStyleSVGPaint: 8bytes
nsHTMLReflowState: 8bytes
nsCSSToken: 8bytes
nsCSSScanner: 0bytes :(
CascadeEnumData: 0bytes :(
nsCSSBorderRenderer: 8bytes
nsCSSSelector: 8bytes
nsFrameConstructorState: 8bytes
nsAttrSelector: 8bytes
InlineBackgroundData: 8bytes
nsCSSStyleSheetInner: 8bytes

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm worried some of these might be making things a good bit less readable by separating related things (particularly RuleHash, maybe also nsCSSScanner, nsCSSSelector, nsAttrSelector).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 376905 [details] [diff] [review]
patch [pushed: comment 3]

Please undo the changes to nsCSSScanner and RuleHash.  I think they make the code significantly less readable.

r+sr=dbaron on the rest

If you want to propose changing RuleHash or nsCSSScanner in a different way, please do that in a separate patch.  (The nsCSSToken changes are fine, though; they're in nsCSSScanner.h as well.)

r+sr=dbaron on the rest, although I'm not sure I'm qualified to say that this doesn't make InlineBackgroundData or nsCSSBorderRenderer less readable

Comment 3

[Arpad Borsos [:Swatinem]]

Comment on attachment 376905 [details] [diff] [review]
patch [pushed: comment 3]

http://hg.mozilla.org/mozilla-central/rev/a1fc27041e53