492647 - Attachment reminder should .test, not .exec

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

re.exec() returns an array of the matches, which is particularly uninteresting when the re is "attached" and thus the array is ["attached"]. Since all we want is matched/didn't, .test() is perfect for us.

Comment 1

[rsx11m]

There is also bug 492438 though, requesting the list of matches to be displayed to the user in the dialog for information what triggered it.

Comment 2

[Phil Ringnalda (:philor)]

matchedWords += keywordsArray[i] + " ";

Reporting what matched only requires .exec() in the unlikely case that we embrace input-as-regexp and want to tell people what word was matched by their "attach(ed|ment)\s(?!to)" (and even then, I'm not quite sure that reporting the match rather than the regexp that hit would be the right thing).

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 377006 [details] [diff] [review]
Fix

Looks good. It's simple to change as appropriate in the future if needed. r=mkmelin

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/b616a582c42b