492654 - Addtocollection page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Fred Wenzel [:wenzel]]

This is a page that is currently only seen in JS-disabled state when publishing from an add-on's details page (bug 456139). The other places to add add-ons (collections add and edit pages) are AJAXy and don't use this as a fallback.

What should we do to the page? If we keep it, for fallback only, we should have some useful wording.

If we remove it, we need a different kind of fallback for bug 456139.

Comment 1

[Justin Scott [:fligtar]]

Can we have it go back to the add-on's display page with a box at the top that says "[add-on name] has been added to the [collection name] collection."?

The collection name should be linked to the collection's display page.

Comment 2

[Fred Wenzel [:wenzel]]

Yes we can. Thanks, I'll amend the code in bug 456139 accordingly, then close this bug.

Comment 3

[Fred Wenzel [:wenzel]]

Added a patch containing this to bug 456139.

Comment 4

[Fred Wenzel [:wenzel]]

With bug 456139 landing, this page is gone and has been replaced by a nice little "success" banner on the display page.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of what I see with JS disabled

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> Created an attachment (id=377776) [details]
> Screenshot of what I see with JS disabled

Don't worry, that's bug 490896, which I am fixing at the moment.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Already tested this with JS disabled over in another bug.

Verified FIXED.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"