Closed Bug 492668 Opened 12 years ago Closed 12 years ago

crash [@ nsMsgLocalMailFolder::Rename]

Categories

(Thunderbird :: Folder and Message Lists, defect)

x86
Windows Vista
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: wsmwk, Assigned: rkent)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

crash [@ nsMsgLocalMailFolder::Rename]

#33 crash for 3.0b2. also occurs on 3.0b3pre

stacks are of 2 varieties

bp-31b2055e-b6e7-4417-a025-3519d2090416
0	thunderbird-bin	nsMsgLocalMailFolder::Rename	 mailnews/local/src/nsLocalMailFolder.cpp:1148
1	libxpcom_core.dylib	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
2	thunderbird-bin	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2456
3	thunderbird-bin	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1587
4	libmozjs.dylib	js_Invoke	js/src/jsinterp.cpp:1368
5	libmozjs.dylib	js_Interpret	js/src/jsinterp.cpp:5089
6	libmozjs.dylib	js_Invoke	js/src/jsinterp.cpp:1376
7	libmozjs.dylib	js_InternalInvoke	js/src/jsinterp.cpp:1429
8	libmozjs.dylib	JS_CallFunctionValue	js/src/jsapi.cpp:5118
9	thunderbird-bin	nsJSContext::CallEventHandler	dom/src/base/nsJSEnvironment.cpp:2007
10	thunderbird-bin	nsJSEventListener::HandleEvent	dom/src/events/nsJSEventListener.cpp:247
11	thunderbird-bin	nsXBLPrototypeHandler::ExecuteHandler	content/xbl/src/nsXBLPrototypeHandler.cpp:341
12	thunderbird-bin	nsXBLKeyEventHandler::ExecuteMatchedHandlers	content/xbl/src/nsXBLEventHandler.cpp:147
13	thunderbird-bin	nsXBLKeyEventHandler::HandleEvent	content/xbl/src/nsXBLEventHandler.cpp:176 

and
bp-d6bee8bf-fd7d-4e3c-b6b3-5587f2090511
0	thunderbird.exe	nsMsgLocalMailFolder::Rename	nsLocalMailFolder.cpp:1142
1	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
2	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2265
3	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1583
4	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1316
Crash occurs on lines like:

  parentFolder->GetFilePath(getter_AddRefs(parentPathFile));

parentFolder comes from a weak reference that is returned from nsMsgDBFolder::GetParentMsgFolder  That routine always returns NS_OK, but in nsMsgLocalMailFolder::Rename the result is checked for failure. Instead, the out parameter needs to be checked for null, as it is in other uses in nsLocalMailFolder.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Attachment #377158 - Flags: superreview?(bienvenu)
Attachment #377158 - Flags: review?(bienvenu)
Attachment #377158 - Flags: superreview?(bienvenu)
Attachment #377158 - Flags: superreview+
Attachment #377158 - Flags: review?(bienvenu)
Attachment #377158 - Flags: review+
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 3.0b3
Checked in: http://hg.mozilla.org/comm-central/rev/fe814b210d8a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Crash Signature: [@ nsMsgLocalMailFolder::Rename]
You need to log in before you can comment on or make changes to this bug.