492702 - gcc 4.5 doesn't have GIMPLE_TUPLE_P

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Brad Hards]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.2; Linux) KHTML/4.2.2 (like Gecko) Fedora/4.2.2-12.fc9
Build Identifier: hg tip
changeset:   432:e261f4cd4fff

During compilation of dehydra tip against gcc trunk, I get this:
/opt/gccsvn/bin/gcc -MD -g3 -Wall -fPIC -DXP_UNIX -DIN_GCC -DHAVE_CONFIG_H -I/home/bradh/devel/gcc-build/gcc -I/home/bradh/devel/gcc-svn/gcc -I/home/bradh/devel/gcc-svn/gcc/. -I/home/bradh/devel/gcc-svn/gcc/../include -I/home/bradh/devel/gcc-svn/gcc/../libcpp/include -I/home/bradh/devel/gcc-svn/gcc/../libdecnumber -I/home/bradh/devel/gcc-svn/gcc/../libdecnumber/bid -I/home/bradh/devel/gcc-build/libdecnumber -I/home/bradh/devel/gcc-build -I/home/bradh/devel/gcc-svn/gcc/cp -I/opt/spidermonkey/include/js -I/opt/spidermonkey/lib -I//home/bradh/local/include/js/   -c treehydra.c
treehydra.c: In function ‘lazy_tree_node’:
treehydra.c:158: warning: implicit declaration of function ‘GIMPLE_TUPLE_P’

It turns out that a gimple tree is always a tuple now. As a workaround, just define it as something that always returns true.

Reproducible: Always

Steps to Reproduce:
1. Build dehydra against gcc trunk
2.
3.
Actual Results:  
warning message, as shown above

Expected Results:  
Clean compilation

Will attach patch.

Comment 1

[Brad Hards]

Attachment: [bad patch - ignore]

Comment 2

[Brad Hards]

Attachment: patch to deal with missing GIMPLE_TUPLE_P

Comment 3

[(dormant account)]

Attachment: alternative

Lets try a different approach. I like to move the code forward rather than keep using obsolete constructs.

Can you check that this solves the issue for you?

Comment 4

[Brad Hards]

I can't edit the attachment, but the patch works for me.

Recommend that patch be committed.

Comment 5

[Brad Hards]

Alternative patch has been committed. Nothing further required.

Comment 6

[Brad Hards]

Comment on attachment 377199 [details] [diff] [review]
alternative

Taras,

Can you remove the review on this? I can't seem to edit it, and BMO is now sending me nuisance alerts once a week.

Brad