492753 - Include add-on name in page title of review page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement)

Description

[:Gijs (he/him)]

If I type in "editors/review" in my awesomebar, I see a lot of pages titled "Editor Tools :: Firefox Add-ons", with url .../editors/review/12345 (for some number instead of 12345)

This is a bit silly, because I can't see what add-on those pages are about. I would be so happy if the add-on's name were included in the page title, because it would help me find the page I'm looking for in History / Awesomebar.

Comment 1

[Fred Wenzel [:wenzel]]

That's a good suggestion, thanks. If by any chance you can provide a patch, I can review it. You'd need to change $this->pageTitle (I believe) in the editors controller.

Comment 2

[:Gijs (he/him)]

Attachment: Stupid patch

Umm, I have no idea what I'm doing when fiddling with AMO, and with CAKE in general... so here goes nothing! I also haven't tested this... :-)

Comment 3

[Fred Wenzel [:wenzel]]

Comment on attachment 377194 [details] [diff] [review]
Stupid patch

Works for me!

Comment 4

[Fred Wenzel [:wenzel]]

I committed this to r25652. Thanks again!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/review/52411?num=1:

<title>Toodledo :: Editor Tools :: Add-ons for Firefox</title>

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"