492754 - Exception when trying to bookmark a page while there is no space left on device [nsINavBookmarksService.insertBookmark]

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090513 Shiretoko/3.5b5pre ID:20090513034609

If the partition where the profile is located is full you will not be able to create any bookmark. That's fine. But we should catch the exception and warn the user?

Steps:
1. Create a profile on an external device e.g. low capacity usb stick
2. Fill-up the usb stick with e.g. dd so no space is left
3. Start the newly created profile
4. Try to bookmark a page

With step 4 the following exception is thrown and not catched:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80630002 [nsINavBookmarksService.insertBookmark]"  nsresult: "0x80630002 (<unknown>)"  location: "JS frame :: file:///Applications/Shiretoko.app/Contents/MacOS/components/nsPlacesTransactionsService.js :: PCIT_doTransaction :: line 428"  data: no]

Comment 1

[Nochum Sossonko [:Natch]]

What is it supposed to do? It's probably returning OOM.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now the star immediately switches back to an empty star. Without any feedback. I don't think that we should confront the user with a dialog but a better explanation e.g as message in the error console would be nice?

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

At that stage a lot of stuff would start to fail, most likely the software could even crash with oom, due to infallible allocators trying to move stuff to virtual memory.
Either this becomes a general bug showing a "your disk is full" notification, or as a Places bug it's wontfix.