Sometimes add-on author not displayed on review page

VERIFIED FIXED in 5.0.6

Status

defect
--
minor
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

10 years ago
STR:

1. Open:
https://addons.mozilla.org/en-US/editors/review/57039

2. Open:
https://addons.mozilla.org/en-US/firefox/addon/9556

AR:
Note how the latter says: "by MP3Tunes <https://addons.mozilla.org/en-US/firefox/user/3207945>" and the former has no author listed

ER:
Would like to see author on review pane too. (Normally it's there, but somehow here it is not?)

Review page HTML in this region looks like: 

        <div>
            <span class="sectionTitle">Authors:</span>

            <ul id="authors">
            <li><a href="/en-US/firefox/user/3207945" > </a></li>            </ul>
        </div>
Assignee

Comment 1

10 years ago
Hmm, it seems it might have to do with the fact this author has no real name, only a nickname? It would be good if we fell back to a nickname if there was no real name available for the editor page...
Hint: The HTML helper has a method linkUserFromModel() that you can dump a user array into. Look at the addons/display page (and many others) for an example.
Assignee

Comment 3

10 years ago
Posted patch Switch to using nickname (obsolete) — Splinter Review
So, I propose we just switch it to nickname, just like on the public side of AMO. Seeing as anyone can put in whatever they want for real names (John Smith for everyone!), I'm not sure how it would be any worse - but I presume that nobody is allowed to have an empty nickname field, as those have been here since the beginning of time. I hope?
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #377239 - Flags: review?(fwenzel)
Comment on attachment 377239 [details] [diff] [review]
Switch to using nickname

People can put whatever they want into their nicknames as well... Currently, only one out of the three name fields is required. You should really use the library function that I pointed out.
Attachment #377239 - Flags: review?(fwenzel) → review-
Assignee

Comment 5

10 years ago
Oops, sorry - I hadn't seen the comment. As far as I can tell this should work, then...
Attachment #377239 - Attachment is obsolete: true
Assignee

Comment 6

10 years ago
Comment on attachment 377256 [details] [diff] [review]
Use utility function

D'oh, requesting review properly...
Attachment #377256 - Flags: review?(fwenzel)
Attachment #377256 - Flags: review?(fwenzel) → review+
Comment on attachment 377256 [details] [diff] [review]
Use utility function

Close enough for Jazz ;) I changed it a little "User" instead of "Users", minus the argument 0, then it worked. I checked it in to r25662, thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.0.6
Version: 3.0 → 4.x
Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/review/45973; prior to preview cycling the new changes, the last Author: was ">>".

Now, it's ">>stephend":

class="profileLink">stephend</a>
Status: RESOLVED → VERIFIED
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.