492776 - Fork symbolstore.py to address space handling issues

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Since handling paths with spaces is now an issues for bug 492238 as well, I'm just going to fork symbolstore.py to fix the space-handling issues that affect us.

Yes it would be ideal to fix it in toolkit (bug 491073), but I don't have the time/patience/setup to:
- fix and test all the platforms
- fix and test the scm pieces we don't use
- write a different patch (and test it) for mozilla-central, which we don't use
- test Firefox builds with the change
- try to get 1.9.0 approval

I'll land a fork with the fix in our scripts/ directory. If someday bug 491073 gets fixed (or we move to m-c trunk and want the new features enough to do all the above), we can always unfork.

Comment 1

[Stuart Morgan]

Attachment: symbolstore.py hack/fix

This is the diff between what I'm landing in our scripts directory and the (1.9.0) toolkit version (not including a comment I stuck at the top explaining the fork)

This isn't really a great fix--for example, it would break files with " in the path. But since we don't have any of those (and it's unlikely to be in anyone's tree path), and we do have files with spaces, that's good enough for me.

Comment 2

[Stuart Morgan]

Attachment: makefile change

Here's the Makefile.in change I'll land with it, switching to our copy and adding in Default Plugin.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 377197 [details] [diff] [review]
makefile change

r=ardissone

I tested this locally with the fork and it works as expected.

Comment 4

[Stuart Morgan]

Landed on CVS trunk.