492808 - Forced clobber message is misleading

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

If a slave's build directory is empty, and the clobber server returns a non-null value for the clobber date, the current clobberer script will treat that as a trigger to force a clobber.  This results in a message "Server is forcing a clobber", which various other tools pick up on.

The problem is that 99% of the time, the build directory has been clobbered by some other build needing space.  Also, saying that the server is forcing a clobber is misleading because the build directory is already clobbered.

We should fix the clobberer script so it doesn't warn about this common case.

We should also indicate when a clobber build is occurring.

Comment 1

[Chris AtLee [:catlee]]

Attachment: Only do a server forced clobber if we know what our last clobber time was

Comment 2

[Chris AtLee [:catlee]]

Attachment: Detect if we have no build directory, and set the purge_clobber property accordingly

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 377219 [details] [diff] [review]
Detect if we have no build directory, and set the purge_clobber property accordingly

Had a chance to give this a spin in staging ?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 377218 [details] [diff] [review]
Only do a server forced clobber if we know what our last clobber time was

Looks fine.

Comment 5

[[e-mail] (:bhearsum)]

Sounds like this is yours, Chris.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 377218 [details] [diff] [review]
Only do a server forced clobber if we know what our last clobber time was

changeset:   282:34afe709615b

Comment 7

[Chris AtLee [:catlee]]

Attachment: Detect if our clobber time was None, and set purged_clobber accordingly

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 381370 [details] [diff] [review]
Detect if our clobber time was None, and set purged_clobber accordingly

Looks like the various states are exclusive, so that the elif is fine. r+

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 381370 [details] [diff] [review]
Detect if our clobber time was None, and set purged_clobber accordingly

changeset:   331:4ce9333c706b