492814 - no progress indicator when installing an add-on from out side of manager

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

When installing an add-on from outside the add-on manager (such as tara's fennecmark) I get no progress indicator.  We simply show the add-on manager which eventually shows a restart button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This is becoming a typical problem for the panel views. We don't want to fully initialize them, but we do want to listen for certain triggers and then do some appropriate actions.

In this case we were calling back into the ExtensionsView, but parts of it were not initialized.

The patch adds some checks so it's safe to call back into certain methods. We also check to see if we should display the restart notification when showing the view for the first time.

The addon alerts (start and finish) are now working and the restart notification is visible when showing the extensions view.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/98bf817c7201

Comment 3

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11535 has been created to regression test this bug.