Allegro favicon should be changed

VERIFIED FIXED

Status

Mozilla Localizations
pl / Polish
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Hubert Gajewski, Assigned: marcoos)

Tracking

({fixed1.9.0.12, productization, verified1.9.1})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Allegro, one of search providers (in Polish Firefox) changed favicon. We should apply this change in 3.0.x, 3.5 an trunk.
Can you attach a patch for review? I've put the new icon's data: url in the URL field in this bug.

Thanks.
Keywords: productization
OS: Linux → All
Hardware: x86 → All
(Reporter)

Comment 2

9 years ago
Created attachment 377928 [details] [diff] [review]
Patch mozilla-1.9.1 & trunk
Attachment #377928 - Flags: review?(marcoos+bmo)
(Assignee)

Updated

9 years ago
Attachment #377928 - Flags: review?(marcoos+bmo)
Attachment #377928 - Flags: review+
Attachment #377928 - Flags: approval1.9.0.11?
Attachment #377928 - Flags: approval1.9.0.11? → approval1.9.0.12?
Comment on attachment 377928 [details] [diff] [review]
Patch mozilla-1.9.1 & trunk

1.9.0.11 is code frozen, pushing to 1.9.0.12.
Marek, Hubert: do you want this in for 3.5 RC1? If so, please land the patch before the codefreeze, which is on Wednesday, noon UTC. Thanks.
Attachment #377928 - Flags: review+
(Reporter)

Comment 5

9 years ago
(In reply to comment #4)
Checked in.
(In reply to comment #5)
> (In reply to comment #4)
> Checked in.

For future reference: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/pl/rev/43a670b38ecc

Thanks.
Keywords: fixed1.9.1
(Assignee)

Comment 7

9 years ago
I'd really wish searchplugins could just fetch and cache the favicon, just like Prefs > Applications do... :)

Comment 8

9 years ago
(In reply to comment #7)
> I'd really wish searchplugins could just fetch and cache the favicon, just like
> Prefs > Applications do... :)

Interesting point.  Marek, do you think we should file a bug for that idea?

Comment 9

9 years ago
Comment on attachment 377928 [details] [diff] [review]
Patch mozilla-1.9.1 & trunk

a=me for 1.9.0.12, please land with a good comment and do the keyword dance for fixing and verification.
Attachment #377928 - Flags: approval1.9.0.12? → approval1.9.0.12+
Checking in browser/searchplugins/allegro-pl.xml;
/l10n/l10n/pl/browser/searchplugins/allegro-pl.xml,v  <--  allegro-pl.xml
new revision: 1.3; previous revision: 1.2
done

Oh, this retro feel of ye olde CVS... ;-)

Seth, I'm not sure if my wish from comment #7 is compatible with the OpenSearch spec, but on the other hand MozSearch is not OpenSearch, so... :)
Keywords: fixed1.9.0.12
Marking as fixed.

Verified with Fx 3.5 and 3.5.1.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1 → verified1.9.1
Resolution: --- → FIXED
v.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.