Allegro, one of search providers (in Polish Firefox) changed favicon. We should apply this change in 3.0.x, 3.5 an trunk.
Can you attach a patch for review? I've put the new icon's data: url in the URL field in this bug. Thanks.
Created attachment 377928 [details] [diff] [review] Patch mozilla-1.9.1 & trunk
Attachment #377928 - Flags: approval126.96.36.199? → approval188.8.131.52?
Comment on attachment 377928 [details] [diff] [review] Patch mozilla-1.9.1 & trunk 184.108.40.206 is code frozen, pushing to 220.127.116.11.
Marek, Hubert: do you want this in for 3.5 RC1? If so, please land the patch before the codefreeze, which is on Wednesday, noon UTC. Thanks.
(In reply to comment #4) Checked in.
(In reply to comment #5) > (In reply to comment #4) > Checked in. For future reference: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/pl/rev/43a670b38ecc Thanks.
I'd really wish searchplugins could just fetch and cache the favicon, just like Prefs > Applications do... :)
(In reply to comment #7) > I'd really wish searchplugins could just fetch and cache the favicon, just like > Prefs > Applications do... :) Interesting point. Marek, do you think we should file a bug for that idea?
Comment on attachment 377928 [details] [diff] [review] Patch mozilla-1.9.1 & trunk a=me for 18.104.22.168, please land with a good comment and do the keyword dance for fixing and verification.
Attachment #377928 - Flags: approval22.214.171.124? → approval126.96.36.199+
Checking in browser/searchplugins/allegro-pl.xml; /l10n/l10n/pl/browser/searchplugins/allegro-pl.xml,v <-- allegro-pl.xml new revision: 1.3; previous revision: 1.2 done Oh, this retro feel of ye olde CVS... ;-) Seth, I'm not sure if my wish from comment #7 is compatible with the OpenSearch spec, but on the other hand MozSearch is not OpenSearch, so... :)
Marking as fixed. Verified with Fx 3.5 and 3.5.1.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1 → verified1.9.1
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.