Closed Bug 492855 Opened 15 years ago Closed 15 years ago

build failure at jsinterp.h:558 with a C compiler (liveconnect, etc)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Gavin, Assigned: sayrer)

Details

Attachments

(1 file, 1 obsolete file)

ifdef it
871 bytes, patch
brendan
: review+
Details | Diff | Splinter Review 
/Users/gavin/mozilla-central/js/src/jsinterp.h:558: error: syntax error before ‘&’ token
Attached patch patch (obsolete) — — Splinter Review 
Assignee: general → gal

        Attachment #377257 -
        Flags: review?(brendan)

    
    

    
  
Bug 492705 also fixes this, fwiw.

    
    

    
  
Comment on attachment 377257 [details] [diff] [review]
patch

Let's do the jsdtracef.cpp thing instead.

/be

        Attachment #377257 -
        Flags: review?(brendan) → review-
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE

    
    

    
  
To keep liveconnect building, I had to stick this on the branch today. :/

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a1319ee53a74

What should we do?
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

    
    

    
  
Could the branch |ifdef __cplusplus| around js_GetUpvar to avoid this?

    
    

    
  
(In reply to comment #7)
> Could the branch |ifdef __cplusplus| around js_GetUpvar to avoid this?

Yes, that would be better. Less likely to conflict too.

/be

    
    

    
  
OK, I'll clean this up later today, after a few green cycles go.

    
  
Assignee: gal → sayrer

    
  
Summary: build failure at jsinterp.h:558 with dtrace enabled → build failure at jsinterp.h:558 with a C compiler (liveconnect, etc)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        ifdef it
        — 
          — Splinter Review
      

    


  
r? just to make sure I did it right

http://hg.mozilla.org/releases/mozilla-1.9.1/raw-rev/caaee69d62eb

        Attachment #377257 -
        Attachment is obsolete: true

        Attachment #377905 -
        Flags: review?(brendan)

    
    

    
  
Comment on attachment 377905 [details] [diff] [review]
ifdef it

Sure. We have three cases of #ifdef __cplusplus with comment to right on same line:

jsinterp.h:#ifdef __cplusplus /* Aargh, LiveConnect, bug 442399. */
jsinterp.h:#ifdef __cplusplus /* Aargh, LiveConnect, bug 442399. */
jsobj.h:#ifdef __cplusplus /* FIXME: bug 442399 removes this LiveConnect requirement. */

No need to standardize but common grep-bait might pay off.

/be

        Attachment #377905 -
        Flags: review?(brendan) → review+

    
  
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: