492884 - getMostRecentFolderForFeedURI should use the livemarks service instead of annos directly

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Dietrich Ayala (:dietrich)]

using the livemark service would allow using the cache instead of hitting the db directly.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 384100 [details] [diff] [review]
patch v1.0

>+  /**
>+   * Determines whether the feed URI is a currently registered livemark.
>+   *
>+   * @param aFeedURI
>+   *        Feed URI to look for.
>+   *
>+   * @returns the found livemark folder id, or -1 if nothing was found.
>+   */
>+  long long getLivemarkForFeedURI(in nsIURI aFeedURI);
> 

can you kill the whitespace on the following line

also, should be getLivemarkIdForFeedURI to be more explicit about what's returned.

>   /**
>-   * TODO: this should use the livemark service's cache of folder ids (bug 492884).
>+   * Get the most recently folder item id for a feed URI.

s/ly//

>+
>+const LMANNO_FEEDURI = "livemark/feedURI";

we should probably hang the internal annos off of PlacesUtils. please file a bug for this.

Comment 3

[Marco Bonardo [:mak]]

(In reply to comment #2)
> >+
> >+const LMANNO_FEEDURI = "livemark/feedURI";
> 
> we should probably hang the internal annos off of PlacesUtils. please file a
> bug for this.

filed bug 499743

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.1

addressed comments

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.2

wrong one

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.3

ugh, lost the test.

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.4

fix a typo, this should be finally ready for check-in.

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/be7dbb414de8