Closed Bug 492914 Opened 15 years ago Closed 15 years ago

TM: trace aborts due to flat closure analysis bug

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: bzbarsky, Assigned: brendan)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files, 1 obsolete file)

Attached file testcase (obsolete) —
See attached testcase. It triggers aborts like so:

abort: 5500: fp->scopeChain is not global or active call object
Abort recording of tree /Users/bzbarsky/test.js:3@17 at /Users/bzbarsky/test.js:12@0: name.

Note that if I inline looper() in the testcase (so replace that function call to looper() with two nested loops with f() called in the inner loop) then we trace this.
Flags: blocking1.9.1?
Blocks: 460050
Attached patch one-line fixSplinter Review
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #377341 - Flags: review?(mrbkap)
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.1
fwiw, I tried that patch on the go game.  It fixed all the board.js scope chain aborts except for the two that actually change the value of a variable the close over.
Comment on attachment 377336 [details]
testcase

Not this bug's test, naming f changes semantics and differs from the go game. I'll put this in a new bug.

/be
Attachment #377336 - Attachment is obsolete: true
Attachment #377341 - Flags: review?(mrbkap) → review+
(In reply to comment #4)
> I'll put this in a new bug.

bz kindly offered to do the deed.

/be
Filed bug 492918 on that first testcase.
Summary: TM: trace aborts if function that accesses upvar is passed to another function, then called → TM: trace aborts due to flat closure analysis bug
Fixed in tm:

http://hg.mozilla.org/tracemonkey/rev/010768e6119c

/be
Whiteboard: fixed-in-tracemonkey
We should take this for 1.9.1 after a bit of baking.

/be
Flags: blocking1.9.1? → blocking1.9.1+
http://hg.mozilla.org/mozilla-central/rev/010768e6119c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 493260
(In reply to comment #11)
> This has been backed out from 1.9.1:
> 
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f497e113346f

yep, sorry I missed the note here.
No longer depends on: 493466
Depends on: 640880
You need to log in before you can comment on or make changes to this bug.