492923 - remove mail-16.gif ... and mail-16.png?

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

With Linux and Windows I think this an easy no questions asked patch as they don't even reference the icon at all.

With the Mac it appears that the jar.mn file references mail-16.png and then appears to use mail-16.gif in the compose and addressbook css files.  I'm not sure what this image is for other than making us look like an ass at certain points.

Phil, any ideas about the Mac?

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: removes mail-16.gif from qute and gnomestripe themes

here's the patch for the qute and gnomestripe themes

Comment 2

[Phil Ringnalda (:philor)]

Sadly, the story is pretty much what it looks like.

SeaMonkey has a Window menu on all platforms, and uses icons with the menuitems for its various window types.

Thunderbird has those menuitems in the Tools menu on Windows/Linux, where we claim they are "menuitem-iconic icon-mail16 menu-iconic". Bug 285772, not quite the dawn of Thunderbird themes but the start of them being completely independent, landed mail-16.gif unused and unjarred in Qute, and used message-mail.png (and abcard.png for icon-addressbook16) in its place, until bug 345887, the Tb2 theme update, stopped using images for the menuitems (without removing the classes from the XUL).

Bug 285772 landed mail-16.png unused but jarred in Pinstripe, and tried to use mail-16.gif in its place. Then bug 353588 switched us from using our own Mac Window menu code to using the toolkit Window menu code, which lost us the menuitems for window types, and bug 365755 added them back via overlay, not doing anything about a class for displaying an icon because displaying an icon for those sorts of menuitems in a Mac Window menu is utterly wrong and non-native.

So since we don't have those menu icons anywhere, and don't want those menu icons anywhere (unless having them would be properly native on Linux), the fix is to remove the files and make http://mxr.mozilla.org/comm-central/search?string=%28addressbook|mail%2916&regexp=on&find=%2Fmail%2F return no results.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: removes all traces of the mail-16 icon and friends

wow, thanks!

Hopefully this is everything you asked for.  I also cleaned up the xul elements I touched while I was in there and reordered some of the attributes as best I could remember you guys liking them...

Comment 4

[Phil Ringnalda (:philor)]

No reason to keep the menu-iconic and menuitem-iconic classes, is there? Near as I can tell, menu-iconic is totally wrong, since that class is only used for menu.menu-iconic and menubar > menu.menu-iconic, when you're creating a menu that has an icon next to the menu label, and menuitem-iconic is just giving us a binding with an image that we don't want or do anything with.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

yeah, that makes sense.  I'm in the middle of a rebuild and will add that to the patch when it's done.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: updated patch w/ menu(item)-iconic removed

here's the updated version

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 377591 [details] [diff] [review]
updated patch w/ menu(item)-iconic removed

Almost: mail-16.png was jarred, just not used, so with the file removed but the line not removed from the jar.mn, you get a build failure.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/cd7fc1c8e3b6

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

oh, nice catch.  thanks!