493052 - The places search throbber continues to animate even when it's not visible

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I haven't been able to reproduce this yet. But I'm pretty sure I've seen it at least once. I'll try to come up with better information if/when I can reproduce it. 

One thing to look into is whether images continue to animate even if they are display:none.

Comment 1

[Nochum Sossonko [:Natch]]

Pretty sure there's a bug on this, can't find it atm.

Comment 2

[Nochum Sossonko [:Natch]]

Actually I was thinking of bug 483841 (I thought there was a follow-up to that), see the comments and the fix from that bug.

Comment 3

[Johnathan Nightingale [:johnath]]

Couldn't we do what we do for the favicon/throbber in tabs, and just swap in the throbber icon with CSS when we're doing a places search?  Then we could remove the stack too, right?  Less XUL is virtuous...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, I think we could do that.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #0)
> One thing to look into is whether images continue to animate even if they are
> display:none.

We actually use display:none already:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#38

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Yeah, but Jeff was seeing the underlying image object continue to animate despite that. Bug 483841 means we'll no longer repaint unnecessarily, but there's still work we can avoid here by actually unloading the image.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #5)
> (In reply to comment #0)
> > One thing to look into is whether images continue to animate even if they are
> > display:none.
> 
> We actually use display:none already:
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#38

I know, the hypothesis is that display:none is insufficient to stop the animating.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

We might want to explore not bothering to animate display:none images, but that would require some layout->imglib interaction that's probably not worth investigating at this point. A front-end fix should be pretty simple, though.

Comment 9

[Dão Gottwald [:dao]]

Has this been reproduced now?

Comment 10

[Jeff Muizelaar [:jrmuizel]]

No. So I would consider this low priority.

Comment 11

[Tracy Walker [:tracy]]

responding to qawanted: How did you tell it was animating when it wasn't visible?

Comment 12

[Marco Bonardo [:mak]]

we don't have anymore the throbber.