493062 - Highlight/delete multiple site containers in history sidebar only deletes first one

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[Marc Buchmann]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.9) Gecko/2009040821 Firefox/3.0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.9) Gecko/2009040821 Firefox/3.0.9

When cleaning up browsing history by selecting multiple site 'folders' in the history sidebar, only the first entry of the selection group is removed

Reproducible: Always

Steps to Reproduce:
1. Perform normal browsing session to populate history
2. Open history sidebar (ctrl-h)
3. Highlight multiple sites (when in 'view by date/site' (click on a folder, shift-arrow to select more above/below)
4. Hit delete

Actual Results:  
Only the first entry selected is deleted, the others you selected are de-selected

Expected Results:  
All highlighted entries should be deleted.

Comment 1

[Marc Buchmann]

One more thing: selecting all with ctrl-a will delete all entries as expected.

Comment 2

[Pastor]

I confirm, bug appeared in 3.0. Now in 3.5 (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090615 Firefox/3.5) it still presents.

Maybe related: https://bugzilla.mozilla.org/show_bug.cgi?id=226350

Platform: tested on XP and Vista, both affected.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

i can confirm this behavior, looks like we don't iterate correctly

Comment 4

[Pastor]

As I understand, no fix in 3.5 branch?

Comment 5

[Pastor]

Tried 3.6b1 pre (20091014035152), the bug is present. Is it going to be an "everlasting" bug?

Comment 6

[Pastor]

Same in 3.6 RC1. Hope it will be fixed in 3.7.

Comment 7

[Boris]

Same in fx 3.6.4rc1

Comment 9

[David McRitchie]

This not a duplicate of 260367.

This bug specifically is about deleting multiple selected history containers with example  "By Date and Site" and would also apply to "By Site" and to "By Date". 

Bug 260367 does not mention containers, and in fact specifically mentions items (as opposed to containers).  There is no problem deleting selected multiple history items such as in "By Most Visited", and "By Last Visited" so it had probably been marked invalid on that account (not reproducible from directions).

Multiple selection can also be done with Ctrl and Shift keys, provided one clicks to the left of the container/site icon.  It is not necessary to restrict selection to just use Shift+arrow key to avoid going to a single item in a container rather than selecting it. (http://kb.mozillazine.org/Viewing_the_browsing_history_-_Firefox#Deleting_history_items)

Comment 10

[(mostly gone) XtC4UaLL [:xtc4uall]]

Restoring bug's status based on comment 0 & comment 9 opposed to Bug 260367 comment 0.

Comment 11

[Pastor]

Tried 4.0b1 build1 - the bug is present.

Comment 12

[Pastor]

Same in 4.0b3

Comment 13

[Pastor]

Same in 4.0b9

Comment 14

[Pastor]

No fix in 6.0a2. Please fix it for 6.0 final.

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

Please don't comment in the bug for each new version. If the bug is open then it has not been fixed.

Comment 16

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.