493084 - Mozmill test for verifying pop-ups are allowed

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

This test goes hand in hand with the "Pop-up Allowed" smoketest in litmus (see URL).

Comment 1

[u279076]

Attachment: TESTCASE: Rev2

Test case for checking that pop-ups are allowed, display, and that no warning appears.

Comment 2

[u279076]

Attachment: TESTCASE: Rev3

Added clean up code to restore the pref.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 377717 [details]
TESTCASE: Rev3

Some of the comments I gave to the popups blocking test also applies here.


>var teardownModule = function(module) {
>  // Restore the Block Pop-ups pref to checked
>  prefcontroller.click(new elementslib.Elem( prefcontroller.tabs.Content.button));
>  var pref = new elementslib.ID(prefcontroller.window.document, "popupPolicy");
>  if (!pref.getNode().checked) {
>    prefcontroller.click(pref);
>  }
>}

Please also waitForElement here and please close the preferences dialog and all the created popups so we are in the initial state. Otherwise we will run into problems with following tests.

>var testPopUpBlocked = function(){
>  // Ensure the pref is not checked
>  prefcontroller.click(new elementslib.Elem( prefcontroller.tabs.Content.button));
>  var pref = new elementslib.ID(prefcontroller.window.document, "popupPolicy");
>  if (pref.getNode().checked) {
>    prefcontroller.click(pref);
>  }

waitForElement is missing here too.

>  // Check that the Window count has not changed since the pop-up test
>  // (i.e. no new windows appeared)
>  if (preWindowCount >= postWindowCount) {
>    throw "Error: Pop-ups were blocked";
>  }     

Mmh I wonder if we should check for the exact number of opened pop-ups. I don't think they will change the amount. 

>  var panel = new elementslib.Lookup(controller.window.document, '/id("main-window")/id("browser")/id("appcontent")/id("content")/anon({"anonid":"tabbox"})/anon({"anonid":"panelcontainer"})');  
>  if (panel.hasChildNodes) {
>    if (panel.firstChild.nodeName == "xul:notificationbox") {
>      throw "Error: Warning displayed";
>    }
>  }

Even with the notification box open I get no failure here.

Comment 4

[u279076]

Bug 493671 prevents me from solving this bug.

Comment 5

[u279076]

Attachment: Test Case

This test case works with a couple of caveats:

1. The test blocks pop-ups sometimes.  Run the test using CMD+R and the test will display all pop-ups sometimes and block some of the pop-ups other times.  This should always allow pop-ups to display.

2. There is an assertNodeNotExist() for the status bar icon.  This test fails saying the icon exists when in fact it doesn't.

Comment 6

[u279076]

Attachment: Patch: testPopupsAllowed.js

This patch includes the test case for allowing pop-ups to appear.  The problems I specified earlier appear to be rectified.  I've run the test 20 times without problems.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 385032 [details] [diff] [review]
Patch: testPopupsAllowed.js

>+  for each (window in mozmill.utils.getWindows()) {
>+    if (window.content && window.content.location == "http://www.mozilla.org") {

Please add an enclosing '/' to the URL.

>+/**
>+ * Test to make sure pop-ups are not blocked
>+ *
>+ * @throws Pop-ups were blocked
>+ * @throws Status bar icon is visible
>+ */

For the test function itself we don't need the throws param description.

>+  // Check for the warning bar by looking for the X button
>+  var panel = new elementslib.Lookup(controller.window.document, '/id("main-window")/id("browser")/id("appcontent")/id("content")/anon({"anonid":"tabbox"})/anon({"anonid":"panelcontainer"})');
>+  UtilsAPI.delayedAssertNode(controller, panel);
>+  var childNodes = panel.getNode().childNodes;
>+  var xButton = new elementslib.Lookup(controller.window.document, '/id("main-window")/id("browser")/id("appcontent")/id("content")/anon({"anonid":"tabbox"})/anon({"anonid":"panelcontainer"})/{"flex":"1","id":"' + childNodes[0].id + '"}/{"value":"popup-blocked","image":"chrome://browser/skin/Info.png","priority":"5","type":"warning"}/anon({"class":"notification-inner outset","flex":"1","xbl:inherits":"type","type":"warning"})/{"ondblclick":"event.stopPropagation();","class":"messageCloseButton tabbable","xbl:inherits":"hidden=hideclose","oncommand":"document.getBindingParent(this).close();"}');
>+  controller.assertNodeNotExist(xButton);

Can you please separate the different steps with an empty row? This block is really hard to read.

>+  // Check for the status bar icon
>+  var icon = new elementslib.ID(controller.window.document, "page-report-button");
>+  // This icon is very poorly designed.  It always exists
>+  // and it is always visible.  When the icon is supposed
>+  // to be hidden it is given a size of 0,0.
>+  if (icon.getNode().clientHeight > 0) {
>+    throw "Status bar icon is visible";
>+  }

Ok, this is probably not the best way. As what I have seen is that you can use the CSS display property. Same like in the pop-up blocker test.

>+  // Make sure the pref is unchecked
>+  var pref = new elementslib.ID(controller.window.document, "popupPolicy");
>+  var checked = pref.getNode().checked;

Please add waitForElement before accessing the pref element.

Comment 8

[u279076]

Attachment: Patch: testPopupsAllowed.js

Suggested revisions made.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 385173 [details] [diff] [review]
Patch: testPopupsAllowed.js

Looks good! I have only made the same small tweaks like I did for the pop-ups blocking test.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Checked-in: http://hg.mozilla.org/qa/mozmill-tests/rev/b9a1121397a8

Comment 11

[u279076]

Verified.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Follow-up patch to fix not closing popup windows

We need this fix to make sure to close all popups on Windows and Linux. I haven't an idea why that is working on OS X but now we have a much cleaner way in identifying popups. Using the URL was kinda flaky.

Comment 13

[u279076]

Comment on attachment 397112 [details] [diff] [review]
Follow-up patch to fix not closing popup windows

Code looks fine.  Both tests work.  r+

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/d23ca114f1a6
http://hg.mozilla.org/qa/mozmill-tests/rev/d23ca114f1a6

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.