add deadlock asserts to Win32 VMPI spinlock

VERIFIED FIXED in flash10.1

Status

Tamarin
Virtual Machine
P3
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: cpeterson, Assigned: Lars T Hansen)

Tracking

unspecified
flash10.1
All
Windows Vista
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
Build Identifier: 

The Win32 VMPI spinlock implementation (SpinLockWin) does not allow for recursive locking. These asserts would have been helpful when debugging a recent deadlock.

This patch also combines the Win32 and Win64 code paths.

Reproducible: Always




P4 Change 523793 by chrispet@chrispet-vista on 2009/05/14 15:16:44
(Reporter)

Updated

9 years ago
Attachment #377548 - Attachment is patch: true
Attachment #377548 - Attachment mime type: application/octet-stream → text/plain
Attachment #377548 - Flags: review?(stejohns)

Updated

9 years ago
Attachment #377548 - Flags: review?(treilly)
Attachment #377548 - Flags: review?(stejohns)
Attachment #377548 - Flags: review?(lhansen)

Comment 2

9 years ago
Comment on attachment 377548 [details] [diff] [review]
patch

reassigning review to Lars + Tommy
(Assignee)

Comment 3

9 years ago
Comment on attachment 377548 [details] [diff] [review]
patch

This looks OK to me, and I appreciate the #ifdef removal as well.

If Tommy approves as well I can land it (I recently refactored the Windows spinlocks so the patch won't apply cleanly but there should be no other complications).
Attachment #377548 - Flags: review?(lhansen) → review+

Updated

9 years ago
Attachment #377548 - Flags: review?(treilly) → review+

Updated

9 years ago
Assignee: nobody → lhansen
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x

Comment 4

9 years ago
This patch didn't land but I did land one that added these assert for mac and win platforms.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.