Closed Bug 493122 Opened 13 years ago Closed 7 years ago

Add test for cookie removal in pb, from the crh dialog and permission changes in the page info dialog

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: Natch, Unassigned)

References

Details

Attachments

(1 file)

tests to follow shortly.
Blocks: 482260
Blocks: 491759
Attached patch pb enter/exitSplinter Review
Doug, here is the test I was using, can you check if this fails for you as well?
Attachment #377896 - Flags: review?(doug.turner)
Comment on attachment 377896 [details] [diff] [review]
pb enter/exit

This test will fail in SeaMonkey and other applications which do not have the private browsing service available.  You need to handle this case in your test.
Attachment #377896 - Flags: review?(doug.turner) → review-
(In reply to comment #2)
> (From update of attachment 377896 [details] [diff] [review])
> This test will fail in SeaMonkey and other applications which do not have the
> private browsing service available.  You need to handle this case in your test.

Sure, but I'll wait for an answer to comment 1 before I update the test.
this will not work.

basically, what you have is the NetworkGeolocationProvider code -- when it is running -- will watch for private mode changes.  If it sees one, then it clears the access token.

What you probably have to do is something like:


1) make sure access tokens are not set
2) enter PB mode
3) go to a geolocation page
4) exit PB mode
5) make sure that the access tokens are not set.
If I just include a call to the geolocation service (i.e. navigator.geolocation.getCurrentPosition(function(pos){});) would that work?

I'm a bit worried of actually trying to get the access-token set by geo code for two reasons:

1) Under some circumstances no cookie is set at all.
2) I'm not keen on relying on a live network, that may cause intermittent oranges.
Ping?
Can't land this test without first fixing bug 491759. I'm on this, as soon as I see some progress with that bug, I'll update this here.
pb test landed in bug 491759, I'm not sure what else is tested (re the crh and page info dialog), I'll defer to dougt to make the decision. Are any other tests wanted here?
->default
Assignee: highmind63 → nobody
The geolocation services no longer use cookies for a while now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.