493131 - Shorten DM strings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Talked to Madhava about shorten some text in the DM. Decided to remove the extra "File" labels from the DM download buttons:
* "Find File" -> "Find"
* "Open File" -> "Open"

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 377581 [details] [diff] [review]
patch

I think we need to rev the entity names to notify localizers who are currently localizing fennec. r=me with that.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/4ab07df8bd1a

<rant>
I did it this time, but I find the practice of updating text entity names to be an _extremely_ bad practice. It creates too many possibilities for breaking code that does not even need to be touched. One of the benefits of pulling strings out of the code is not needed to touch the code and potentially break it.
</rant>

Comment 3

[Brian Crowder]

Don't the localization tools capture this kind of revision requirement anyway?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

No, they don't. I wholeheartedly agree: it sucks.

Comment 5

[Dão Gottwald [:dao]]

bugspam