493156 - lots of 1-caller functions in mailCommands.js

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Comment 1

[Joey Minta]

Attachment: patch v1

doh... silly enter button

Here's the situation
  only MsgUnsubscribe calls UnSubscribe
  only MsgSubscribe calls Subscribe
  only MsgSaveAsFile calls SaveAsFile
  only MsgSaveAsTemplate calls SaveAsTemplate
  only MsgMarkAsFlagged calls MarkSelectedMessagesFlagged
  only MsgNewFolder calls getDestinationFolder
  but nobody calls MsgNewFolder
  nobody calls NewFolder either

the odd capitalization in UnSubscribe also led to a bug in deleting certain folders from the folder-pane.

Comment 2

[Magnus Melin [:mkmelin]]

Won't this regress multi-select unsubscribe from news?

Comment 3

[Joey Minta]

I don't see how it ever worked, given that the UnSubscribe function expected a single folder, but the MsgSubscribe function passed it an array. Maybe you can provide me more detailed steps?

Comment 4

[Magnus Melin [:mkmelin]]

Ah yeah seems all subscribe is indeed broken :(

Comment 5

[Magnus Melin [:mkmelin]]

all unsubscribe

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 377606 [details] [diff] [review]
patch v1

Getting pretty late in the game to just completely break Subscribe, I'd think. The first problem is obvious, trying to pass the undefined preselectedMsgFolder instead of preselectedFolder, but then once you get the dialog open and try to subscribe to a newsgroup, clicking OK just silently fails.

Comment 7

[:aceman]

Looks like this needs finishing. I was told Joey is away.