Closed
Bug 493239
Opened 16 years ago
Closed 15 years ago
Unfork CreateVirtualFolder/getSearchTermString and put them where they belong
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jminta, Assigned: jminta)
Details
Attachments
(1 obsolete file)
These functions are almost identical between suite/ and mail/. getSearchTermString is entirely identical, and the only difference in CreateVirtualFolder is that the mail/ version includes the line |newFolder.prettyName = newName;| I've kept that line in the unforked version.
The only place where CreateVirtualFolder is called is in virtualFolderProperties's onOK function. Furthermore, CreateVirtualFolder was the only consumer outside of that file of getSearchTermString. We can therefore move both functions into virtualFolderProperties, where they belong.
Attachment #377687 -
Flags: superreview?(bienvenu)
Attachment #377687 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #377687 -
Attachment is obsolete: true
Attachment #377687 -
Flags: superreview?(bienvenu)
Attachment #377687 -
Flags: review?(bienvenu)
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 377687 [details] [diff] [review]
patch v1
this has been bit-rotted by the ui refactoring...
|
Assignee | |
Comment 2•15 years ago
|
||
THis is now invalid as a result of the refactoring. These functions disappeared from what I can tell.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•