All users were logged out of Bugzilla on October 13th, 2018

Optimize setting currentTarget

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 377716 [details] [diff] [review]
patch

Event doesn't need to have currentTarget when there are no listener for it.
So setting currentTarget can be moved from 
nsEventTargetChainItem::HandleEvent to nsEventListenerManager::HandleEvent.
This does show up in a shark profile.
Will ask review after some testing.
(Assignee)

Comment 1

10 years ago
Comment on attachment 377716 [details] [diff] [review]
patch

This did pass tests on tryserver.
Can't test locally because of bug 493366
Attachment #377716 - Flags: superreview?(jst)
Attachment #377716 - Flags: review?(jst)
Attachment #377716 - Flags: superreview?(jst)
Attachment #377716 - Flags: superreview+
Attachment #377716 - Flags: review?(jst)
Attachment #377716 - Flags: review+
(Assignee)

Comment 2

10 years ago
http://hg.mozilla.org/mozilla-central/rev/2961a5be1e42
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.