493293 - "Advanced" search tab does not blend into search box background gradient

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Fred Wenzel [:wenzel]]

Attachment: Pre-fix screenshot

That's the same as bug 438713 for the old layout.

The background color needs to be: #26395A

Comment 1

[Fred Wenzel [:wenzel]]

Natbat, please fix this upstream so it won't overwrite our fix. I fixed it locally in revision r25799.

The patch to fix this is:

diff --git a/site/app/webroot/css/amo2009/main.css b/site/app/webroot/css/amo2009/main.css
index 51627b2..cf69a01 100644
--- a/site/app/webroot/css/amo2009/main.css
+++ b/site/app/webroot/css/amo2009/main.css
@@ -2251,7 +2251,7 @@ ol.pagination li a:active {
     border-radus: 0 0 5px 5px;
     border: 1px solid #021437;
     border-top: none;
-    background-color: #223355;
+    background-color: #26395A;
 }
 
 /* @group Expanded search form */

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Post-fix screenshot

Comment 3

[Natalie Downe]

Hello Frédéric,

Thanks for spotting this I have applied your patch in our local build. Revision 2510.

Kind regards,
Natalie

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; I don't see this fixed, and bug 490889 is resolved fixed.

Comment 5

[Fred Wenzel [:wenzel]]

The color is still the same as in comment 1 though. Which one do you think it needs to be instead?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Yes, my bad; color is fine -- I was focusing on the |   | part of the tab that extends into the border of the search border -- but that's a separate "bug", if indeed a bug at all (and probably by design).

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; sorry, all.