493296 - Activity Manager, gloda: don't mention things w/ 0 messages

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

I see in my activity manager: "Indexed 0 messages in <foldername>"

That seems unnecessary =)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Yup, I mentioned this in bug 469051, comment 16 and in the code at http://hg.mozilla.org/comm-central/file/6786ebf24275/mail/components/activity/modules/glodaIndexer.js#l235.

I was conflicted about it, but in the end I biased towards reporting this information thinking that perhaps it would help us diagnose problems users report with the gloda indexer.  bienvenu also prefers the current behavior per bug 469051, comment 18.

I guess it depends on whether users use the Activity Manager more to track normal activity or to troubleshoot aberrant behavior.  If the former, it probably doesn't make sense to show these messages; if the latter, it probably does.

I don't really have a strong feeling either way and am fine with either.  Someone just needs to make a decision.

Comment 2

[David Ascher (:davida)]

At the very least I'd change the words to be "No new messages to index in folder <blah>".  But my vote is to not include that, as from a troubleshooting POV we have log4moz, IMO.

In general, I think the Activity Manager should try to not be too verbose -- I have another bug i want to file about collapsing delete/move notifications, especially as we can't undo them.

Comment 3

[David :Bienvenu]

(In reply to comment #1)

> I was conflicted about it, but in the end I biased towards reporting this
> information thinking that perhaps it would help us diagnose problems users
> report with the gloda indexer.  bienvenu also prefers the current behavior per
> bug 469051, comment 18.

Hmm, I was being a little bit facetious :-) it might be nice for me.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: suppresses gloda indexer events that didn't index messages

Hmm, ok, the preponderance of the evidence suggests that suppressing these events is better overall than showing them.  Here's a patch that does that.  Holding off requesting for review until I can successfully build with and test this patch (my build is currently failing for an apparently unrelated reason).

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 379684 [details] [diff] [review]
patch v1: suppresses gloda indexer events that didn't index messages

Tested, and it behaves as expected, so requesting review and super-review.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 379684 [details] [diff] [review]
patch v1: suppresses gloda indexer events that didn't index messages

Thank you for the patch!

Comment 7

[David :Bienvenu]

Comment on attachment 379684 [details] [diff] [review]
patch v1: suppresses gloda indexer events that didn't index messages

thx for the patch, Myk.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset http://hg.mozilla.org/comm-central/rev/ed644c7a353b.