493306 - Collections add page: Preserve form choices on error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P3)

Description

[Fred Wenzel [:wenzel]]

If, for example, you do not enter a collection name on the "create collection" page, it will return an error, however, add-ons selected before will not persist.

They should.

Comment 1

[Chuck Baker]

Same for exceeding description limit of 200 characters.  After error message, all add-ons previously selected disappear.

Comment 3

[Fred Wenzel [:wenzel]]

(From bug 504380 comment #0)
> I am trying to create a new collection and the page is difficult to deal. It
> says: " The description should be less than 200 characters. " But there is not
> JavaScript that can count to let me know. In addition, for every cycle it says
> that there is an error, it clears my settings: 
> 
> * [ ] Only people I invite can view my collection  // it unchecks thebox
> * It also clears the Addon Collection Name

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Preserve form choices on error. This preserves (only) the checked add-ons on error, as well as the other form fields.

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 393579 [details] [diff] [review]
Patch, rev. 1

success!

Comment 8

[Fred Wenzel [:wenzel]]

yay! r48917.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/add:

* with name, no desc: "You must provide a description of your collection."
* with description, no name: "You must give your collection a name."
* with both :-)