493505 - Fennec on WinMo can't resolve font name aliases properly

Status: RESOLVED DUPLICATE of bug 488626

(Core :: Graphics, defect)

Description

[Takuro Ashie [:ashie]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
Build Identifier: 

I noticed that fennec can't recognize Japanese font names on Japanese ennvironemnt.
For example, IPA font (http://ossipedia.ipa.go.jp/ipafont/fontspec.html) has 2 names for a same font face:

  * IPAPGothic
  * IPA Pゴシック

But fennec can only recognize the former one (IPAPGothic) on certain situation.


Reproducible: Always

Steps to Reproduce:
1. Install the IPAPGothic font to Japanese WinMo system.
2. Change the system font to "IPA Pゴシック" by using PocketHand (http://smart-pda.net/useful7+index.id+7.htm) or other registry editors.
3. Launch the fennec and visit http://www.yahoo.co.jp/.

Actual Results:  
The program crashes on startup because it can't find any fonts at http://hg.mozilla.org/mozilla-central/file/1a0cd8aa1bfb/gfx/thebes/src/gfxFT2Fonts.cpp#l244.

Expected Results:  
The Fennec launches and it shows Japanese characters using IPAPGothic font.

This bug is originaly reported at https://bugzilla.mozilla.org/show_bug.cgi?id=489752.

Fennec on WinMo manages system fonts by using the Freetype, but sometimes it uses Win32 API to resolve font names:

  * http://hg.mozilla.org/mozilla-central/file/1a0cd8aa1bfb/gfx/thebes/src/gfxFT2Fonts.cpp#l244
  * http://hg.mozilla.org/mozilla-central/file/1a0cd8aa1bfb/gfx/thebes/src/gfxWindowsPlatform.cpp#l500
  * http://hg.mozilla.org/mozilla-central/file/1a0cd8aa1bfb/gfx/thebes/src/gfxWindowsPlatform.cpp#l350

The Freetype manages fonts using ASCII font names, but Win32 APIs like EnumFontFamilies will return Japanese font names on Japanese environment. This will cause conflicts. 
Please notice that it may not reproduced on English environment because Win32 APIs will return ASCII font name for the face to resolve alias names.

Comment 1

[Takuro Ashie [:ashie]]

Attachment: Resolve font names using Freetype

I think Fennec should use Freetype to resolve font name aliases to avoid such conflicts.
I made a patch for this issue. It stores aliase names for each fonts at startup using FT_Get_Sfnt_Name.

Comment 2

[Takuro Ashie [:ashie]]

Attachment: Revised patch

Fix a bug.

Comment 3

[Takuro Ashie [:ashie]]

Attachment: Font name patch v3

Also store TT_NAME_ID_FULL_NAME.