Closed
Bug 493509
Opened 13 years ago
Closed 13 years ago
shouldn't fire "suspend" when all data has been loaded
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
5.55 KB,
patch
|
cajbir
:
review+
roc
:
approval1.9.1+
|
Details | Diff | Splinter Review |
That seems weird.
Flags: wanted1.9.1+
|
Assignee | |
Comment 1•13 years ago
|
||
I'm not sure how it happened, but it did: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1242612507.1242618034.10755.gz#err1
|
|
Assignee | |
Comment 2•13 years ago
|
||
I guess it happens when we fire ResourceLoaded from nsOggDecoder::FirstFrameLoaded. We call nsHTMLMediaElement::FirstFrameLoaded, which suspends, and then we call ResourceLoaded, which sets the network state to NETWORK_LOADED. Then the 'suspend' event handler runs and triggers these test failures.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #378043 -
Flags: review?(chris.double)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
||
Updated•13 years ago
|
Attachment #378043 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e3a2e35b1d24
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs review] → [needs 191 landing]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #378043 -
Flags: approval1.9.1+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5e3fb97dc92e
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•