493522 - Some Wi-Fi related tools don't work after using Firefox's geolocation

Status: VERIFIED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Atsushi Sakai]

Attachment: Patch v1.0

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090517 Minefield/3.6a1pre

Steps to reproduce:
1. Install and run PlaceEngine Client http://www.placeengine.com/showe/install
2. Click Get Location button in PlaceEngine Client and make sure it can retrieve Wi-Fi information. (Though "Cannot determine location" or "Cannot find any access points" are OK.)
3. Run Firefox and open http://people.mozilla.com/~jbalogh/geo.html , and click "Share Location".
4. Click Get Location button in PlaceEngine Client.

Actual result:
"Cannot get Wi-Fi information" displayed in PlaceEngine Client.

Expected result:
"Cannot get Wi-Fi information" should not occur in PlaceEngine Client.


Another steps to reproduce:
1. Use Lenovo ThinkPad X61.
2. Press Fn + F5 or run C:\Program Files\ThinkPad\ConnectUtilities\AcFnF5.exe, and wireless dialog opens.
3. Make sure "802.11 (Wiless LAN)" is listed in the wireless dialog.
4. Run Firefox and open http://people.mozilla.com/~jbalogh/geo.html , and click "Share Location".
5. Press Fn + F5 or run C:\Program Files\ThinkPad\ConnectUtilities\AcFnF5.exe, and wireless dialog opens.

Actual result:
"802.11 (Wiless LAN)" is not listed in the wireless dialog.

Expected result:
"802.11 (Wiless LAN)" should be listed in the wireless dialog.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 378019 [details] [diff] [review]
Patch v1.0

nits:

should use PR_FALSE and PR_TRUE.  


set dosDeviceDefined to something before passing it into DefineDosDeviceIfNotExists

No curl braces needed around UndefineDosDevice


I will clean these up when I land this patch.

bz, sr please?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking; we shouldn't affect other tools :)

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 378019 [details] [diff] [review]
Patch v1.0

asking vlad.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 378019 [details] [diff] [review]
Patch v1.0


>-bool DefineDosDeviceIfNotExists(unsigned short* device_name) {
>+bool DefineDosDeviceIfNotExists(unsigned short* device_name, bool& dosDeviceDefined) {

Pass dosDeviceDefined as a pointer, not a ref -- it's an out-only parameter, otherwise you end up with uninitialized variable warnings and just looks weird in general.

Looks fine otherwise.

Comment 5

[Doug Turner (:dougt)]

Attachment: comments addressed

vlad, one final r= since I also made some changes here.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 378133 [details] [diff] [review]
comments addressed

What happened to PRBool usage here?

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 378133 [details] [diff] [review]
comments addressed

Looks fine!

Comment 8

[Doug Turner (:dougt)]

bz, when I looked at the rest of the file, we were using "true" and "false".  I didn't want to introduce another macro that defines to true or false.  If you think it makes sense, i could covert everything to nspr types, but I didn't think it was worth it.

Comment 9

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/79577242f5e1

Comment 10

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b4fb44c5e5eb

Comment 11

[Atsushi Sakai]

Verified fixed with
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1242707154/firefox-3.6a1pre.en-US.win32.zip
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090518 Minefield/3.6a1pre BuildID=20090518212554
and also
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-1.9.1-win32/1242707952/firefox-3.5b5pre.en-US.win32.zip
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090518 Shiretoko/3.5b5pre BuildID=20090518213912

Thanks!