Closed Bug 493528 Opened 11 years ago Closed 11 years ago

Parallel build error with PalmSync

Categories

(MailNews Core Graveyard :: Palm Sync, defect)

x86
Windows Server 2003
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file)

The new SeaMonkey buildbots are building with -j4 and PalmSync enabled, and sometimes run into a compile error with that:

make[7]: *** No rule to make target `../../../addrbook/src/addrbook_s.lib', needed by `palmsync.dll'.  Stop.
make[7]: *** Waiting for unfinished jobs....
make[7]: Leaving directory `/e/builds/slave/comm-1.9.1-win32-nightly/build/objdir/mailnews/extensions/palmsync/src'
make[6]: Leaving directory `/e/builds/slave/comm-1.9.1-win32-nightly/build/objdir/mailnews/extensions/palmsync'
make[5]: Leaving directory `/e/builds/slave/comm-1.9.1-win32-nightly/build/objdir/mailnews/extensions'
make[6]: *** [libs] Error 2
make[5]: *** [palmsync_libs] Error 2
make[4]: *** [extensions_libs] Error 2
make[4]: *** Waiting for unfinished jobs....

Note that _in the following output_ (i.e. the "waiting for unfinished jobs"), I see this:

rm -f addrbook_s.lib
lib -NOLOGO -OUT:"addrbook_s.lib"  nsAbManager.obj nsAbRDFDataSource.obj nsDirectoryDataSource.obj nsAbCardProperty.obj nsDirPrefs.obj nsAddrDatabase.obj nsAbDirProperty.obj nsAbAddressCollector.obj nsAddbookProtocolHandler.obj nsAbMDBDirProperty.obj nsAbMDBDirectory.obj nsAbMDBCard.obj nsAbBSDirectory.obj nsAddbookUrl.obj nsAbDirFactoryService.obj nsAbMDBDirFactory.obj nsAbDirectoryQuery.obj nsAbDirectoryQueryProxy.obj nsAbBooleanExpression.obj nsAbDirectoryRDFResource.obj nsAbQueryStringToExpression.obj nsAbView.obj nsVCard.obj nsVCardObj.obj nsMsgVCardService.obj nsAbLDIFService.obj nsAbContentHandler.obj nsAbOutlookDirFactory.obj nsAbOutlookDirectory.obj nsAbWinHelper.obj nsMapiAddressBook.obj nsWabAddressBook.obj nsAbLDAPDirectory.obj nsAbLDAPDirFactory.obj nsAbLDAPCard.obj nsAbLDAPListenerBase.obj nsAbLDAPDirectoryQuery.obj nsAbLDAPDirectoryModify.obj nsAbBoolExprToLDAPFilter.obj nsAbLDAPAutoCompFormatter.obj nsAbLDAPReplicationService.obj nsAbLDAPReplicationQuery.obj nsAbLDAPReplicationData.obj nsLDAPAutoCompleteSession.obj  
link -NOLOGO -DLL -OUT:import.dll -PDB:import.pdb -SUBSYSTEM:WINDOWS  nsImportModule.obj    ./module.res -NXCOMPAT -SAFESEH -DYNAMICBASE -MANIFEST:NO  -DEBUG -OPT:REF -OPT:nowin98   -IMPLIB:fake.lib  ../src/import_s.lib ../text/src/imptext_s.lib ../comm4x/src/imp4mail_s.lib  ../eudora/src/impEudra_s.lib  ../oexpress/importOE_s.lib  ../outlook/src/impOutlk_s.lib   ../../base/util/msgbsutl_s.lib   ../../../mozilla/dist/lib/unicharutil_s.lib ../../../mozilla/modules/libreg/src/mozreg_s.lib ../../../mozilla/dist/lib/xpcom.lib ../../../mozilla/dist/lib/xpcom_core.lib ../../../mozilla/dist/lib/nspr4.lib ../../../mozilla/dist/lib/plc4.lib ../../../mozilla/dist/lib/plds4.lib    kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib   
   Creating library fake.lib and object fake.exp
echo not_ranlib addrbook_s.lib
not_ranlib addrbook_s.lib

so the lib is built correctly, but after PalmSync already caused the build to fail by needing it.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1242630000.1242637006.9936.gz&fulltext=1 is a log exposing this on a nightly cycle.

This is a matter of PalmSync not being able to be built in parllel the way it's done. Is there a simple solution?
This is a patch taking extensions out of the parallel build and making it serial instead, as proposed by Mark on IRC.
I can't test this on actual Windows without being checked in though, as the buildbots pull official source and clobber everything, including the source, before each build.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #378034 - Flags: review?(bugzilla)
Comment on attachment 378034 [details] [diff] [review]
Do a serial instead of parallel invocation for extensions

Let's give it a go.
Attachment #378034 - Flags: review?(bugzilla) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/2507774c8987
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
The first Windows nightly cycle with that patch is green. Doesn't tell if it fully helped because we sometimes happened to have green cycles without it as well, but it's at least not a bad sign :)
Product: MailNews Core → MailNews Core Graveyard
You need to log in before you can comment on or make changes to this bug.