493567 - Top Movers are all 0

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Alex Buchanan [:abuchanan]]

On the homepage, http://www.spreadfirefox.com/, the top movers are all 0 points.  Something seems wrong.

Comment 1

[Alex Buchanan [:abuchanan]]

looking at the database dump from this morning, it looks as though points are recorded successfully.  I found an error in the logs,

"""
Sunday, May 17, 2009 - 09:06

Cron has been running for more than an hour and is most likely stuck.
"""
@ http://www.spreadfirefox.com/admin/logs/event/12287202

the next entry...
"""
Cron run exceeded the time limit and was aborted.
"""

Drupal is limiting the amount of time cron can run.  Since affiliates takes longer than most cron processes on SFx, it isn't getting time to finish.

Cron is running now, and hopefully it will complete.

I think a more scalable solution would be to create a script outside of the regular drupal cron jobs, that can start the affiliates tally process without a time limit.

Comment 2

[Alex Buchanan [:abuchanan]]

oremj, can you give me the most recent output from run.pl?  

This is the script that parses the moz.com and d.m.o logs to look for Spread Firefox Affiliates traffic.  It outputs a file SQL inserts.  

I think the output is named sfx_affl.sql, you could tell by looking for the cron job that runs `perl run.pl` 

I don't know where this script runs.  If you tell me I can write it on the wiki, for future reference.

Comment 3

[Alex Buchanan [:abuchanan]]

oremj, also, could you please pastebin a copy of the config.pl file?  thanks

It's looking like new affiliates referrals aren't being inserted correctly, and I'll need these to debug

Comment 4

[Alex Buchanan [:abuchanan]]

with these bugs, we fixed this problem...

bug 493763
bug 493844
bug 493643

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www.spreadfirefox.com/; QA can assume that the totals are correct due to the 70+ automated unit tests we have for affiliate totals; visual inspection shows they're all there, and appear to be correct.

Comment 6

[Michael Morgan [:morgamic]]

Nice job -- tests are awesome! :)