Closed
Bug 493611
Opened 15 years ago
Closed 15 years ago
use $(MAKE) throughout the unit tests instead of make
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mpk, Assigned: mpk)
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b99])
Attachments
(1 file)
Some unices fail during the unit tests because their make isn't GNU make. Using $(MAKE) instead will allow running those tests on said platforms (when e.g. gmake is available and the tests were invoked as "gmake check").
Attachment #378106 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #378106 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 1•15 years ago
|
||
Comment on attachment 378106 [details] [diff] [review] patch making unit tests use $(MAKE) instead of make (mozilla-central) [Checkin: Comment 1 & 3] http://hg.mozilla.org/mozilla-central/rev/4e4f6175bfeb
Attachment #378106 -
Attachment description: patch making unit tests use $(MAKE) instead of make (mozilla-central) → patch making unit tests use $(MAKE) instead of make (mozilla-central)
[Checkin: Comment 1]
Comment 2•15 years ago
|
||
(In reply to comment #1) > > http://hg.mozilla.org/mozilla-central/rev/4e4f6175bfeb That was after fixing context for { patching file config/Makefile.in Hunk #1 FAILED at 160 1 out of 1 hunks FAILED patching file config/tests/src-simple/Makefile.in Hunk #1 FAILED at 51 1 out of 1 hunks FAILED }
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Comment 3•15 years ago
|
||
Comment on attachment 378106 [details] [diff] [review] patch making unit tests use $(MAKE) instead of make (mozilla-central) [Checkin: Comment 1 & 3] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d2b456a063b3 (as is...)
Attachment #378106 -
Attachment description: patch making unit tests use $(MAKE) instead of make (mozilla-central)
[Checkin: Comment 1] → patch making unit tests use $(MAKE) instead of make (mozilla-central)
[Checkin: Comment 1 & 3]
Updated•15 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing] → [fixed1.9.1rc1]
Updated•15 years ago
|
Whiteboard: [fixed1.9.1rc1] → [fixed1.9.1b99]
You need to log in
before you can comment on or make changes to this bug.
Description
•