Update homepage promo admin module to use DB for taglines and names

RESOLVED FIXED in 5.0.7

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P2
normal
RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: osunick, Assigned: clouserw)

Tracking

unspecified
5.0.7
x86
Mac OS X

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
For 5.0.6, we had to use static files for the home page promo module, but this needs to move into the DB so we can update featured collections on-demand.
(Reporter)

Updated

9 years ago
Assignee: nobody → clouserw
Priority: -- → P2
(Assignee)

Comment 1

9 years ago
Created attachment 384812 [details] [diff] [review]
SQL you gotta run

Renaming a misnamed key that conflicts with my new table and creating the new table.
Attachment #384812 - Flags: review?(fwenzel)
(Assignee)

Comment 2

9 years ago
Created attachment 384813 [details] [diff] [review]
v1

This pretty much just copies the scaffolding from Platforms.  This would probably be automatic if we weren't using cake! ;)

Also worth mentioning, creating new features gives a whole bunch of SQL errors but it still works.  The other ones (platforms, categories, etc.) do the same thing so I think fixing it is low priority and out of scope for this bug.

If this gets r+'d the only thing left in this bug is a script to load the current strings from the .po into the database.
Attachment #384813 - Flags: review?(fwenzel)

Updated

9 years ago
Attachment #384812 - Flags: review?(fwenzel) → review+
Comment on attachment 384812 [details] [diff] [review]
SQL you gotta run

you want to add this to schematic.
Comment on attachment 384813 [details] [diff] [review]
v1

Seems to work well!
Attachment #384813 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 5

9 years ago
(In reply to comment #3)
> (From update of attachment 384812 [details] [diff] [review])
> you want to add this to schematic.

Can't add it until you commit and get a revision number, right?
Hm yea, I was thinking the same thing earlier. Don't know if I like the whole revision number thing for our DB migrations. I had to make one up for bug 497276, because otherwise it would not be applied for users who already ran the schematic script before.
(Assignee)

Comment 7

9 years ago
r28392 for what we have so far
(Assignee)

Comment 8

9 years ago
Created attachment 385124 [details] [diff] [review]
import l10n

Import the L10n from the .po's.  I've got a script that generates this now.  w00t.
Attachment #385124 - Flags: review?(fwenzel)
(Assignee)

Comment 9

9 years ago
Created attachment 385125 [details] [diff] [review]
use the promobox stuff

> If this gets r+'d the only thing left in this bug is a script to load 
> the current strings from the .po into the database.

Yeah, that's pretty much a lie.  I forgot that we actually have to use this in the code, not just CRUD the tables.
Attachment #385125 - Flags: review?(fwenzel)

Updated

9 years ago
Attachment #385124 - Flags: review?(fwenzel) → review-
Comment on attachment 385124 [details] [diff] [review]
import l10n

At least line 175 is broken, it has invalid quotes.
(Assignee)

Comment 11

9 years ago
Created attachment 385150 [details] [diff] [review]
fix my lame sauce

aww, old copy of the file.
Attachment #385124 - Attachment is obsolete: true
Attachment #385150 - Flags: review?(fwenzel)
Comment on attachment 385125 [details] [diff] [review]
use the promobox stuff

I didn't see any problems with it, works for me.
Attachment #385125 - Flags: review?(fwenzel) → review+
Comment on attachment 385150 [details] [diff] [review]
fix my lame sauce

Yup, this data works.
Attachment #385150 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 14

9 years ago
in r28519 & SQL run on preview.  Migration script in r28521.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.