493616 - Auto-complete for add-on names does not prompt for add-on-"A9"

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Log into you add on account
2.Navigate to the collections home page
3.Click create a new collection
4.Enter name,description for the add-on.
5.Try to add A9 as one of the add-ons.

observed behavior:
auto-complete fails to look for A9.Unable to add this search tool to the collection

additional info:
Able to add other search tools to the collection.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

iirc, this is because we have the search term word-length set to 3, no?

Comment 2

[Fred Wenzel [:wenzel]]

I can confirm this; it is currently expected, though it may indeed be unpleasant.

Autocompletion (like anywhere else on the page) does not start before four characters are entered, in order to avoid excessive amounts of returned data.

A possible improvement for this would be exact matching for add-on names *under* four characters and only starting to match fuzzily once the text entered has four characters or more.

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #1)
> iirc, this is because we have the search term word-length set to 3, no?

no, it's not using the full-text search. Also, the search-term word length is not 3. Didn't we remove it altogether? Or shorten it to 2? I don't remember...

Comment 4

[Wil Clouser [:clouserw]]

> A possible improvement for this would be exact matching for add-on names
> *under* four characters and only starting to match fuzzily once the text
> entered has four characters or more.

This is a cool idea

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Autocomplete starting at 2 characters

This works for me as advertised. I didn't think matching on one letter only made sense, but 2 and 3 letters will be matched exactly now, followed by our regular fuzzy matching on 4+ letters.

Comment 6

[Fred Wenzel [:wenzel]]

r26018.

Comment 7

[krupa raj[:krupa]]

This is not working for me.

Screencast :http://screencast.com/t/Vmo3rAPP

Am I missing something?

Reopening...

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks like this was fixed only for the manage/edit add-ons collections page (https://preview.addons.mozilla.org/en-US/firefox/collections/edit/8ece4ed1-6ee3-2468-fb92-0915ffd6465b#addons), not the Add functionality on

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

... https://preview.addons.mozilla.org/en-US/firefox/collections/add (sorry)

Comment 10

[Fred Wenzel [:wenzel]]

(In reply to comment #8)
> Looks like this was fixed only for the manage/edit add-ons collections page
> not the Add functionality on

That's true, my bad :( I'll fix that. Sorry!

Comment 11

[Fred Wenzel [:wenzel]]

Fixed in r26075.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/add

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"