Edits to collection names are not reflected in the extension

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Collector Extension
P3
major
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: krupa, Assigned: wenzel)

Tracking

unspecified
5.0.6

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
steps to reproduce:
1.Create a collection.
2.Subscribe to that collection
3.Tools->addons->subscriptions.Check if the newly subscribe collection is listed.
4.Edit the collection-change the name
5.Check if the changes are reflected in the extension.

expected results:

Changes to the collection name are reflected in the extension

actual results:
changes to collection names are not updated in the extension
(Reporter)

Updated

9 years ago
Severity: normal → major
I think this is a caching issue on the API side. Maybe we can invalidate the cache when a collection is changed, but otherwise, it's not super important to update immediately.
Priority: -- → P3
Target Milestone: BW-M6 → 5.0.6
I see the change in the extension, but only when I hit the refresh collections button.

The extension should update automatically in this case. This can be achieved by triggering the "bandwagonRefresh" event when the collection is renamed (in the same way that it is triggered on a new collection).
A trigger would only work for the user that made the change, not for the subscribers of that collection. But perhaps that's the only important case so that the user doesn't think the change didn't take.

Fred, can we add the refresh trigger when someone makes changes to or deletes a collection?
Assignee: nobody → fwenzel
(Assignee)

Comment 4

9 years ago
Created attachment 378417 [details] [diff] [review]
Patch, rev. 1

This should do.
Attachment #378417 - Flags: review?(rdoherty)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 378417 [details] [diff] [review]
Patch, rev. 1

I'm not able to test this without editing the add-on to no use https for my localhost. But I can verify there are no JS errors and the function is called.
Attachment #378417 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 6

9 years ago
r26023.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Reporter)

Comment 7

9 years ago
It takes a few seconds to update in the website as well as the extension.Marking it verified.
Status: RESOLVED → VERIFIED
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.