493642 - Header and footer login form shouldn't contain hidden_fields

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

Right now the header and footer form convert *any* POST variables on the current page into GET query-string variables when submitting the form, which does a lot of confusing things (like log you out immediately if you came from the logout page, or reset your password if you came from the reset-password page, etc.).

I have a pretty good solution for all this worked out in my mind, and I'll attach a patch with it.

Comment 1

[Max Kanat-Alexander]

The patch I attach will depend on the patch in bug 482556, because otherwise they'd just conflict.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Here we go. To make sure that people use the form that *has* hidden fields when they're submitting something or doing some other LOGIN_REQUIRED action, we hide the header and footer form on LOGIN_REQUIRED pages.

Comment 3

[Frédéric Buclin]

Comment on attachment 378165 [details] [diff] [review]
v1

>=== modified file 'template/en/default/account/auth/login-small.html.tmpl'

>+[% IF !(Bugzilla.page_requires_login && !user.id) %]

Double negation is hard to understand (I had to write the logic on a piece of paper and do some maths to get it). I think the logic is wrong as a logged in user would make the test to be true. IMO, it should be:

 [% IF !Bugzilla.page_requires_login && !user.id %]


Also, I think you should also hide the "Forgot Password" link in the header/footer as it's already available in the main page; what do you think?

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Okay, you had some good points. Here's a new version.

Comment 5

[Frédéric Buclin]

Comment on attachment 381033 [details] [diff] [review]
v2

Looks good to me. r=LpSolit

Comment 6

[Max Kanat-Alexander]

tip:

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.75; previous revision: 1.74
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.19; previous revision: 1.18
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.23; previous revision: 1.22
done


3.4:

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.73.2.1; previous revision: 1.73
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.17.2.2; previous revision: 1.17.2.1
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.21.4.1; previous revision: 1.21
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.20.2.2; previous revision: 1.20.2.1
done