493652 - First-line style applies to two lines when first-letter style also used

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Daniel Veditz [:dveditz]]

The patch for crash bug 429969 (which was actually in bug 429968) caused a regression in the reftest for bug 23604 -- with both a first-letter and first-line style the first-line style applies to the first TWO lines. After a dynamic change (as in the 23604-1.html test) things appear OK, or if you remove the first-letter style.

1.9.0 branch, 1.9.1 seems OK.

Correct:
http://mxr.mozilla.org/mozilla/source/layout/reftests/bugs/23604-1.html

Incorrect:
http://mxr.mozilla.org/mozilla/source/layout/reftests/bugs/23604-1-ref.html

Comment 1

[Daniel Veditz [:dveditz]]

I would imagine this is a common combination.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The best thing to do would be to figure out which patches in 1.9.1 fix the bug and pull them over.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why did this get assigned to me?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry, I don't know. Dan, is there anyone else who could do this? We just need to apply the patch for bug 429968 to where 1.9.1 split from 1.9.0, and then bisect along 1.9.1 to find out where the bug gets fixed.

Comment 5

[Simon Montagu :smontagu]

Attachment: Patch

(In reply to comment #4)
> We just need
> to apply the patch for bug 429968 to where 1.9.1 split from 1.9.0, and then
> bisect along 1.9.1 to find out where the bug gets fixed.

Or we could just look at the changes and try to figure out what other changes might interact with them :-P

This is taken from bug 441418, for the record.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 382473 [details] [diff] [review]
Patch

Approved for 1.9.0.12, a=dveditz for release-drivers

Comment 7

[Simon Montagu :smontagu]

Checking in layout/reftests/bugs/reftest.list;
/cvsroot/mozilla/layout/reftests/bugs/reftest.list,v  <--  reftest.list
new revision: 1.477; previous revision: 1.476
done
Checking in layout/generic/nsTextFrameThebes.cpp;
/cvsroot/mozilla/layout/generic/nsTextFrameThebes.cpp,v  <--  nsTextFrameThebes.cpp
new revision: 3.192; previous revision: 3.191
done

Comment 8

[Kevin Brosnan]

v.
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.12) Gecko/2009070611 Firefox/3.0.12
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090716 Minefield/3.6a1pre